Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotation bug for non-pitched compasses #8605

Merged
merged 4 commits into from
Aug 6, 2019
Merged

Fix rotation bug for non-pitched compasses #8605

merged 4 commits into from
Aug 6, 2019

Conversation

peterqliu
Copy link
Contributor

@peterqliu peterqliu commented Aug 6, 2019

Launch Checklist

Solves #8579. Additionally applies a subtle scaling function to pitched compasses, to enhance legibility at high pitches

before and after:

Screen Shot 2019-08-06 at 12 26 07 PM

Screen Shot 2019-08-06 at 12 59 17 PM

  • briefly describe the changes in this PR
  • manually test the debug page

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, pending linting fixes

@peterqliu peterqliu merged commit 2f870b8 into master Aug 6, 2019
@peterqliu peterqliu deleted the fix-compass branch August 6, 2019 21:42
ryanhamley pushed a commit that referenced this pull request Aug 9, 2019
* apply proper rotation to non-pitched compasses

* scale up tilted compasses slightly to enhance legibility

* fix documentation

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants