Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug pages #8650

Closed
wants to merge 3 commits into from
Closed

Fix debug pages #8650

wants to merge 3 commits into from

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

  • briefly describe the changes in this PR
    • The changes to the debug page in Fix resource loading edge cases #8612 broke the debug pages when served locally via the yarn start-debug command. This is the only configuration I've found to allow the debug pages to work properly when served locally and when tested with a file:// URL
  • manually test the debug page

@mourner
Copy link
Member

mourner commented Aug 16, 2019

Debug pages through yarn run start-debug work fine for me on master — I wonder why they're broken on your side.

@ryanhamley
Copy link
Contributor Author

Well that's weird. I always see http://localhost:9966/access_token_generated.js net::ERR_ABORTED 404 and the page fails to load. I've tried on Node 8 and 10 just to rule out that possibility and I tried in multiple browsers.

@ryanhamley
Copy link
Contributor Author

Ah so, I have always just gone to localhost:9966/debug in my browser. That doesn't work anymore. The URL has to conclude in / or the path to an html file. So localhost:9966/debug/ works fine. My mistake.

@ryanhamley ryanhamley closed this Aug 16, 2019
@ryanhamley ryanhamley deleted the fix-debug-pages branch August 16, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants