Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buggy image coercion so image names resolve correctly #8839

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Fix buggy image coercion so image names resolve correctly #8839

merged 2 commits into from
Oct 9, 2019

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

Fixes #8831

  • briefly describe the changes in this PR
    • this ensures that we don't coerce an already resolved image by disambiguating objects and strings
  • manually test the debug page

asheemmamoowala
asheemmamoowala approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏pending tests.

@chloekraw chloekraw added this to the release-sangria milestone Oct 7, 2019
@ryanhamley
Copy link
Contributor Author

Closing in favor of #8841

@ryanhamley ryanhamley closed this Oct 8, 2019
@ryanhamley ryanhamley deleted the image-coercion-fix branch October 8, 2019 00:15
@ryanhamley ryanhamley restored the image-coercion-fix branch October 8, 2019 23:12
@ryanhamley ryanhamley reopened this Oct 8, 2019
@ryanhamley
Copy link
Contributor Author

I think #8841 probably should be done but it's more of an internal detail with Flow and it's proving to be difficult to get everything working correctly. In the interest of getting a patch out, I'm re-opening this PR since it solves the bug. I've added a render test. @asheemmamoowala

@ryanhamley ryanhamley merged commit 1c7f3f9 into master Oct 9, 2019
@ryanhamley ryanhamley deleted the image-coercion-fix branch October 9, 2019 20:07
ryanhamley pushed a commit that referenced this pull request Oct 9, 2019
Fix buggy image coercion so image names resolve correctly (#8839)
52d76ff
@kkaefer kkaefer mentioned this pull request Oct 11, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asheemmamoowala asheemmamoowala asheemmamoowala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release-sangria
Development

Successfully merging this pull request may close these issues.

styleimagemissing emitted while Image operator deems the image available
3 participants
@ryanhamley @asheemmamoowala @chloekraw