Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow characters outside \w to be used in token #926

Merged
merged 2 commits into from
Jan 12, 2015

Conversation

halset
Copy link
Contributor

@halset halset commented Jan 9, 2015

Some data set may have attribute name with characters outside of [\w-]. One example is the attribute "HØYDE" (=altitude) used in Norwegian Topographical map.

@jfirebaugh
Copy link
Contributor

"Any character other than {, ^, and }" is a little too broad. We want to reserve at least some punctuation marks that we might use for future extensions, e.g. : for token defaults. I wish that JavaScript supported Unicode categories like \p{L}.

@halset
Copy link
Contributor Author

halset commented Jan 12, 2015

The patch is updated with a list of reserved punctuation marks.

@jfirebaugh jfirebaugh merged commit 3d8d750 into mapbox:mb-pages Jan 12, 2015
@jfirebaugh
Copy link
Contributor

Thanks! I'll port to native.

jfirebaugh added a commit to mapbox/mapbox-gl-native that referenced this pull request Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants