Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise step interpolation for lines, increase precision of line progress as needed #9694

Merged
merged 2 commits into from
Jun 9, 2020

Commits on Jun 4, 2020

  1. Increase texture resolution for line gradient for step interpolant

    - Step interpolant now uses gl.NEAREST for texture sampler: This allows
    for hard transition between different line sections when using step
    interpolation. Other use cases are covered by using a smooth interpolation
    type along with gl.LINEAR texture sampler.
    - Step interpolant now uses an increased texture resolution color ramp
    based on the total line length tile coverage to limitate the potential
    precision issues for high coverage. We are still limitated by the precision
    of v_lineprogress currently encoded in a 15bits floating point value.
    
    Reuse color ramp memory placement when already available
    
    Only calculate max distance if clipstart and clipend are defined
    
    Increase precision of line progress when needed
    
    Tile line gradient textures
    
    Review comments
    
    - Eliminate Math.log2 (not available on ie11)
    - Inline and compress evaluation interpolations for line clip by
    specializing it for the use case
    
    Thanks @mourner
    karimnaaji committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    d32ae28 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Optimization pass

    - Use single attribute for uv on x, move computation cpu side
    - Offload fragment shader from a few operations by moving it to vertex
    - More explicit addHalfVertex function block
    karimnaaji committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    2adb186 View commit details
    Browse the repository at this point in the history