Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn about exceeding extent when off by 1px #9753

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

mourner
Copy link
Member

@mourner mourner commented Jun 3, 2020

Closes #8992. A small change to disable "exceeds extent" warnings when the error is off by just 1 pixel, which currently happens on most of our maps on lower zooms because it originates in Mapbox Streets (where geometry is clipped to extent inclusive on the max boundary when it should be exclusive).

1px-off error won't affect rendering, and having this warning appear by default on our maps makes it look like something's wrong when it's not, so I think this small hack is harmless and beneficial enough to be acceptable. We can remove it later, after our tile sources no longer have this issue.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Removed a misleading "geometry exceeds allowed extent" warning when using Mapbox Streets vector tiles.</changelog>

Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove it later, after our tile sources no longer have this issue.

👍

@mourner mourner merged commit 44dc609 into master Jun 3, 2020
@mourner mourner deleted the fix-extent-warning branch June 3, 2020 21:14
sgolbabaei added a commit that referenced this pull request Jun 9, 2020
sgolbabaei added a commit that referenced this pull request Jun 10, 2020
* Cherry pick (#9757) to release-erie

* Cherry pick (#9753) to release-erie

* Cherry pick (#9749) to release-erie

* Cherry pick (#9748) to release-erie
cowboyox pushed a commit to cowboyox/mapbox that referenced this pull request Oct 8, 2024
* Cherry pick (mapbox/mapbox-gl-js#9757) to release-erie

* Cherry pick (mapbox/mapbox-gl-js#9753) to release-erie

* Cherry pick (mapbox/mapbox-gl-js#9749) to release-erie

* Cherry pick (mapbox/mapbox-gl-js#9748) to release-erie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Geometry exceeds allowed extent, reduce your vector tile buffer size"
2 participants