[ios, macos] Initialize offline storage on main thread before snapsho…

…tting
mapbox · Apr 7, 2020 · 9449b65 · 9449b65
1 parent 928f37f
commit 9449b65
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/platform/darwin/src/MGLMapSnapshotter.mm b/platform/darwin/src/MGLMapSnapshotter.mm
@@ -301,9 +301,14 @@ - (void)startWithQueue:(dispatch_queue_t)queue overlayHandler:(MGLMapSnapshotOve
     if (!completion) {
         return;
     }
-    if (!mbgl::Scheduler::GetCurrent()) {
+
+    // Ensure that offline storage has been initialized on the main thread, as MGLMapView and MGLOfflineStorage do when used directly.
+    // https://github.com/mapbox/mapbox-gl-native-ios/issues/227
+    if ([NSThread.currentThread isMainThread]) {
+        (void)[MGLOfflineStorage sharedOfflineStorage];
+    } else {
         [NSException raise:NSInvalidArgumentException
-                    format:@"startWithQueue:completionHandler: must be called from a thread with an active run loop."];
+                    format:@"-[MGLMapSnapshotter startWithQueue:completionHandler:] must be called from the main thread, not %@.", NSThread.currentThread];
     }
 
     if (self.loading) {

diff --git a/platform/darwin/test/MGLMapSnapshotterTests.m b/platform/darwin/test/MGLMapSnapshotterTests.m
@@ -62,10 +62,6 @@ - (void)setUp {
     [super setUp];
 
     [MGLAccountManager setAccessToken:@"pk.feedcafedeadbeefbadebede"];
-
-    // Initialize file system and run loop before snapshotting.
-    // https://github.com/mapbox/mapbox-gl-native-ios/issues/227
-    (void)[MGLOfflineStorage sharedOfflineStorage];
 }
 
 - (void)tearDown {