This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Update label languages for Mapbox Streets v8.3 #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-l10n-vi-zh-Hant-169
branch
from
c2ad261
to
277f296
Compare
1ec5
commented
Feb 21, 2020
| @@ -89,17 +89,17 @@ @implementation MGLVectorTileSource (Private) | |||
| https://www.mapbox.com/vector-tiles/mapbox-streets-v8/ | |||
| */ | |||
| static NSArray * const MGLMapboxStreetsLanguages = @[ | |||
| @"ar", @"de", @"en", @"es", @"fr", @"ja", @"ko", @"pt", @"ru", @"zh", | |||
| @"zh-Hans", | |||
| @"ar", @"de", @"en", @"es", @"fr", @"ja", @"ko", @"pt", @"ru", @"vi", | |||
There was a problem hiding this comment.
-[NSExpression mgl_expressionLocalizedIntoLocale:] has logic to fall back from zh-Hant to zh if the style happens to be using Streets source v7: mapbox/mapbox-gl-native#12387.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapbox Streets source v8.3 adds names in Traditional Chinese and Vietnamese, according to this documentation. With this change, the
-[MGLStyle localizeLabelsIntoLocale:]and-[NSExpression mgl_expressionLocalizedIntoLocale:]methods can now localize text into these languages (automatically by default if the system’s Preferred Language setting is set to one of them).Fixes #169.
/cc @mapbox/maps-ios @lukasmartinelli @jcsg @lloydsheng