This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Snapshotter (runtime styling) delegates #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrex
reviewed
Mar 23, 2020
Just the manual macosapp thing so far, but I can add an integration test. |
1ec5
commented
Mar 24, 2020
| @@ -107,13 +68,20 @@ - (instancetype)initWithIdentifier:(NSString *)identifier { | |||
| return (mbgl::style::CustomLayer *)super.rawLayer; | |||
| } | |||
|
|
|||
| - (MGLMapView *)mapView { | |||
| if ([self.style.stylable isKindOfClass:[MGLMapView class]]) { | |||
There was a problem hiding this comment.
As implemented in this PR, MGLOpenGLStyleLayer doesn’t support snapshotting, but it wouldn’t be too difficult to make it work if necessary.
|
I’ve added unit tests and snapshot tests of MGLMapSnapshotter that work on both iOS and macOS, unlike the iOS-only integration tests of MGLMapSnapshotter, which will help catch issues like #236. This test suite comes with an easy way to snapshot-test runtime styling for other purposes too. |
Added a protocol and property for MGLMapSnapshotter’s delegate, which it uses for runtime styling. Generalized MGLStyle to be usable in the absence of MGLMapView. Moved MGLOpenGLStyleLayer code around to compile.
1ec5
force-pushed
the
1ec5-snapshotter-runtime-styling-200
branch
from
7aa43fb
to
889a481
Compare
Copy layer visibility settings and translated labels from the main map to the snapshotted map.
1ec5
force-pushed
the
1ec5-snapshotter-runtime-styling-200
branch
from
889a481
to
b5797d3
Compare
julianrex
approved these changes
Mar 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a protocol and property for MGLMapSnapshotter’s delegate, which it uses for runtime styling. Generalized MGLStyle to be usable in the absence of MGLMapView. Moved MGLOpenGLStyleLayer code around to compile.
In macosapp, the File ‣ Export Image command now matches the main map’s layer visibility settings and translated labels.
Added unit tests and snapshot tests of MGLMapSnapshotter that work on both iOS and macOS, unlike the iOS-only integration tests of MGLMapSnapshotter. This test suite comes with an easy way to snapshot-test runtime styling.
Fixes #200, fixes #236.
/cc @mapbox/maps-ios