Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Android integration tests #5211

Closed
jfirebaugh opened this issue Jun 1, 2016 · 14 comments
Closed

Android integration tests #5211

jfirebaugh opened this issue Jun 1, 2016 · 14 comments
Assignees
Labels
Android Mapbox Maps SDK for Android tests

Comments

@jfirebaugh
Copy link
Contributor

In order to prevent regressions like #5108, we need Android integration tests that test actually running a test app.

@jfirebaugh jfirebaugh added Android Mapbox Maps SDK for Android tests labels Jun 1, 2016
@tobrun
Copy link
Member

tobrun commented Jun 2, 2016

I have been trying to avoid them a bit because they tend to be a bit flaky. In this multi platform project with multi contributors it makes sense requiring them on every commit. I'm suggesting to look into the Bitrise emulator approach first before taking the AWS device farm route.

@zugaldia
Copy link
Member

/sub

@tobrun
Copy link
Member

tobrun commented Jun 17, 2016

I have been working on a testapp to test scripts and was able to run it on Bitrise.
Next steps is porting these workflows to gl-native bitrise.yml file.

@tobrun
Copy link
Member

tobrun commented Jul 4, 2016

I was able to store the API access token on s3 and copy it to the correct location in the test app.

Now I'm running into:

com.mapbox.mapboxsdk.testapp.espresso.LatLngBoundsActivityTest > testSanity[test(AVD) - 6.0] FAILED 
    java.lang.Error: eglChooseConfig() failed
    at com.mapbox.mapboxsdk.maps.NativeMapView.nativeInitializeDisplay(Native Method)
Tests on test(AVD) - 6.0 failed: Instrumentation run failed due to 'java.lang.Error'
:MapboxGLAndroidSDKTestApp:connectedDebugAndroidTest FAILED

@tobrun
Copy link
Member

tobrun commented Jul 6, 2016

I reached out to Bitrise to see if they can help resolve the issue with the emulator in bitrise-steplib/steps-start-android-emulator#22.

@bleege
Copy link
Contributor

bleege commented Jul 11, 2016

/sub

@tobrun
Copy link
Member

tobrun commented Jul 11, 2016

I have been looking into how Bitrise is setting up their emulator and was able to reproduce the issue on Bitrise locally. After trying out some configurations I'm starting to think the issue comes from not enabling GPU emulation. Will look into this in more detail and see if I can create an emulator through command line that is able to show our maps.

@tobrun
Copy link
Member

tobrun commented Jul 13, 2016

Been following up with Bitrise folks here. We were able to get GPU emulation configured but now are still hitting a timeout when starting an emulator.

@tobrun
Copy link
Member

tobrun commented Aug 4, 2016

I reached out to Bitrise after I tried running an emulator with GPU emulation in a separate project.
See bitrise-steplib/steps-start-android-emulator#22 (comment)

@zugaldia
Copy link
Member

Good progress here @tobrun. Let me know if you see Bitrise's current state as a blocker, I'm happy to help with the AWS Device Farm approach instead.

@tobrun
Copy link
Member

tobrun commented Aug 12, 2016

@zugaldia after a couple of failed attempts creating an own Bitrise docker image that supports GPU emulation. I'm going to look into AWS device farm by leveraging their gradle integration. This is on my plate to pick up next monday. Current workstation doesn't have aws credentials configured. I'm handling this as highest priority to be able to catch regressions as we have seen with beta release and as mentioned in OP.

@zugaldia
Copy link
Member

zugaldia commented Aug 12, 2016

@tobrun Fantastic 👍

@tobrun
Copy link
Member

tobrun commented Aug 18, 2016

I'm currently working on integrating Firebase device lab in our CI workflow,
if everything goes well this will be finished later today.

@tobrun
Copy link
Member

tobrun commented Aug 18, 2016

Proposed PR for new workflow in #6073

@tobrun tobrun self-assigned this Aug 18, 2016
@tobrun tobrun added this to the android-v4.2.0 milestone Aug 18, 2016
tobrun added a commit that referenced this issue Aug 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android tests
Projects
None yet
Development

No branches or pull requests

4 participants