Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Allow prefetching tiles for all source types #10548

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

brunoabinader
Copy link
Member

Follow up to #7741, we should revisit this feature proposed by @tmpsantos now that #7026 is fixed.

@brunoabinader brunoabinader added the Core The cross-platform C++ core, aka mbgl label Nov 23, 2017
@ChrisLoer
Copy link
Contributor

Awesome, I need to remember to try this out next time I'm stuck with a slow internet connection...

@kkaefer
Copy link
Contributor

kkaefer commented Nov 27, 2017

@ChrisLoer To simulate slow internet connections, you can also use the "Network Link Conditioner". You can obtain it from the Additional Tools package from the Apple Developer website:

network link conditioner 2017-11-27 11-54-46

@brunoabinader
Copy link
Member Author

My assumption about the failing CI tests is that we are checking if the map is loaded based on prefetched tile data. We probably need additional logic to ignore - or even disable prefetch - in still mode.

@brunoabinader
Copy link
Member Author

My assumption about the failing CI tests is that we are checking if the map is loaded based on prefetched tile data. We probably need additional logic to ignore - or even disable prefetch - in still mode.

I've updated this PR to reflect the proposed idea above - we skip prefetching in static mode for two reasons: we don't need intermediary overscaled tiles when generating static images, and prefetched tiles add an extra complexity to the logic we implement for finishing a static render cycle.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants