This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Rework spec function/expression taxonomy (counterpart of gl-js#6521) #11861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 4, 2018 16:24
Ports mapbox/mapbox-gl-js#6521: for the sake of gl-native this only requires tweak to code generation scripts.
jfirebaugh
suggested changes
May 7, 2018
| }; | ||
|
|
||
| global.isInterpolable = function(property) { |
There was a problem hiding this comment.
Doesn't seem to be used.
| @@ -319,9 +319,9 @@ global.propertyDoc = function (propertyName, property, layerType, kind) { | |||
| '* Conditional expressions\n' + | |||
| '* Variable assignments and references to assigned variables\n'; | |||
| const inputVariable = property.name === 'heatmap-color' ? '$heatmapDensity' : '$zoomLevel'; | |||
There was a problem hiding this comment.
Can this use expression.parameters?
| @@ -164,7 +164,7 @@ namespace mbgl { | |||
|
|
|||
| <% if (property.name === 'heatmap-color') { -%> | |||
There was a problem hiding this comment.
Can this use property-type?
|
👍 I left a few uses of |
jfirebaugh
approved these changes
May 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly minor tweaks to codegen scripts to account for the spec taxonomy changes described in mapbox/mapbox-gl-js#6521, plus a few ignores needed to update the gl-js pin. (Nitpick test is failing until that PR is merged to master.)