Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Parse GeoJSONSource description in background #15885

Merged
merged 3 commits into from
Nov 5, 2019

Conversation

pozdnyakov
Copy link
Contributor

Unblocks the UI thread on heavy GeoJSON tiles parsing operation.

The auxiliary Scheduler::scheduleAndReplyValue API and a unit test have been added.

Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/98

@pozdnyakov pozdnyakov added performance Speed, stability, CPU usage, memory usage, or power usage Core The cross-platform C++ core, aka mbgl needs changelog Indicates PR needs a changelog entry prior to merging. labels Nov 4, 2019
@pozdnyakov pozdnyakov self-assigned this Nov 4, 2019
include/mbgl/actor/scheduler.hpp Outdated Show resolved Hide resolved
src/mbgl/util/thread_pool.hpp Show resolved Hide resolved
src/mbgl/style/sources/geojson_source.cpp Show resolved Hide resolved
src/mbgl/style/sources/geojson_source.cpp Outdated Show resolved Hide resolved
@pozdnyakov pozdnyakov force-pushed the mikhail_source_background_parsing branch from f6cf447 to f7170d0 Compare November 4, 2019 16:02
@pozdnyakov pozdnyakov requested a review from a team November 4, 2019 16:02
@pozdnyakov pozdnyakov removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Nov 4, 2019
@pozdnyakov
Copy link
Contributor Author

@tmpsantos Thanks for your comments! Fixed now in the latest patch set

@pozdnyakov pozdnyakov force-pushed the mikhail_source_background_parsing branch from f7170d0 to 7f5773d Compare November 5, 2019 09:04
@pozdnyakov pozdnyakov merged commit 4964f7e into master Nov 5, 2019
@pozdnyakov pozdnyakov deleted the mikhail_source_background_parsing branch November 5, 2019 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants