Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Don't provide multiple responses with the same data for 304 replies #16200

Merged
merged 5 commits into from
Feb 14, 2020

Conversation

alexshalamov
Copy link
Contributor

@alexshalamov alexshalamov commented Feb 13, 2020

In cases when cached resource is useable, yet don't have an expiration timestamp, we provided data to the requester from the cache and the same data was returned once 304 response was received from the network.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • apply needs changelog label if a changelog is needed (remove label when added)

@alexshalamov alexshalamov added needs changelog Indicates PR needs a changelog entry prior to merging. and removed needs changelog Indicates PR needs a changelog entry prior to merging. labels Feb 13, 2020
@alexshalamov alexshalamov marked this pull request as ready for review February 13, 2020 15:19
In cases when cached resource is useable, yet don't have an expiration
timestamp, we provided data to the requester from the cache and the same
data was returned once 304 response was received from the network.
CHANGELOG.md Show resolved Hide resolved
@alexshalamov alexshalamov merged commit ddc7930 into master Feb 14, 2020
@alexshalamov alexshalamov deleted the alexshalamov_fix_double_response branch February 14, 2020 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants