This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Don't add trailing spaces in generate-style-code.js #7886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
force-pushed
the
7886-dont-generate-trailing-spaces
branch
from
b83b1b9
to
ccf3c92
Compare
|
I actually disagreed with #7875. In my opinion, enforcing a code style that differs from Xcode's default only increases friction for new contributors with no material gain. The "no trailing spaces" rule is now the only code style rule we enforce for the iOS and macOS SDKs, which seems a bit strange. A good compromise would have been to enforce the rule only for non-blank lines, or only in components where we actually care. |
|
Superseded by #7372 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
indentfunction adds trailing spaces for multi line strings when generating the code. Follow up to #7875