This repository has been archived by the owner on Apr 10, 2018. It is now read-only.
Remove color ops from v8 #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the chaos between #330 and this PR. Everything's in ship shape and ready for 👀 now. |
| if (isNaN(val[1])) { | ||
| error(key, val, 'number expected, "%s" found', val[1]); | ||
| } | ||
| if (reference.$version <= 7 && val[0] === '@') { |
There was a problem hiding this comment.
I believe constant values will have already been resolved by this point.
lucaswoj
force-pushed
the
v8-remove-ops
branch
from
f588f2d
to
c832ba0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jfirebaugh
ref #308