Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions of StaticMapCriteria style strings #1106

Closed
langsmith opened this issue Jan 21, 2020 · 2 comments · Fixed by #1109
Closed

Bump versions of StaticMapCriteria style strings #1106

langsmith opened this issue Jan 21, 2020 · 2 comments · Fixed by #1109

Comments

@langsmith
Copy link

https://github.com/mapbox/mapbox-java/blob/master/services-staticmap/src/main/java/com/mapbox/api/staticmap/v1/StaticMapCriteria.java has static final Strings to use in the styleId() builder method for MapboxStaticMap.

Opening this ticket to enquire/track whether we need to bump the versions referenced in the StaticMapCriteria. streets-v10 would be streets-v11 and so on.

The sample code snippet in https://docs.mapbox.com/api/maps/#example-request-retrieve-a-static-map-from-a-style uses streets-v11, which makes me think that this ticket is valid in this repo.

cc @mapbox/static-apis

@riastrad
Copy link

@langsmith thank you for cutting the ticket and tapping us in. Yes, these versions should all be updated by one version, as streets-v11, light-v10, etc represent the latest versions of the Mapbox provided "style templates".

@langsmith
Copy link
Author

Great, thanks for the follow-up @riastrad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants