Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped StaticMapCriteria constant style strings to new versions #1109

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

langsmith
Copy link

Resolves #1106 by bumping the StaticMapCriteria class' constant style strings to new versions. They were all outdated by one version.

cc @riastrad

Copy link

@riastrad riastrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good except for the one non-existent style I noted, should be good to go once that is addressed 👍

@langsmith langsmith force-pushed the ls-static-map-criteria-version-bumps branch from e23c2b5 to 1c77aa1 Compare January 22, 2020 20:34
Copy link

@riastrad riastrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍹

@langsmith langsmith force-pushed the ls-static-map-criteria-version-bumps branch from de73f91 to fceeaf4 Compare January 23, 2020 20:38
@langsmith langsmith merged commit 9b821b0 into master Jan 23, 2020
@langsmith langsmith deleted the ls-static-map-criteria-version-bumps branch January 23, 2020 20:44
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment noting that latest version of Navigation guidance styles is v4 cc @langsmith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump versions of StaticMapCriteria style strings
4 participants