Updated DirectionsWaypoint object #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-update-waypoint
branch
from
b75efdf
to
8a64f34
Compare
LukasPaczos
force-pushed
the
lp-update-waypoint
branch
from
8a64f34
to
40f48c0
Compare
| @@ -33,31 +34,32 @@ public static Builder builder() { | |||
| * @return string with the name of the way the coordinate snapped to | |||
| * @since 1.0.0 | |||
| */ | |||
| @Nullable | |||
| @NonNull | |||
There was a problem hiding this comment.
This is technically SemVer although we could treat it as a bug.
There was a problem hiding this comment.
That's my thinking, not a semver for the getter only for the setter, but more of a bug nonetheless.
Guardiola31337
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated nullability annotations and exposed optional
distanceproperty. Refs https://docs.mapbox.com/api/navigation/directions/#waypoint-object.