Workaround for some '&' char encoding #1410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more details in #1409
this PR fixes the case when there is a name like "me & you". Need a better solution to fix encoding in general
&
char in Utf-8 is%26
.we can't replace it in the next block:
because if we do something like this
we will get invalid chars while building a final Url
URL(encodedUri.toASCIIString())
because
%26
will be encoded to%2526
(%
char is%25
in Utf-8)and we will get invalid
%2526
instead of%26
.That's why I replace the char on a final step
I check for start+end space characters (
%20
) not to affect&
chars that are used to connect url params.