added traffic tendecy #1479
Merged
added traffic tendecy #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1479 +/- ##
=========================================
Coverage 76.53% 76.53%
Complexity 908 908
=========================================
Files 128 128
Lines 3929 3929
Branches 568 568
=========================================
Hits 3007 3007
Misses 675 675
Partials 247 247
|
LukasPaczos
reviewed
Aug 17, 2022
There was a problem hiding this comment.
@VysotskiVadim could you add source code documentation as well (not javadoc)?
dzinad
reviewed
Aug 17, 2022
| @@ -30,6 +30,6 @@ dependencies { | |||
|
|
|||
| buildConfig { | |||
| packageName = 'com.mapbox.sample' | |||
| buildConfigField 'String', 'MAPBOX_ACCESS_TOKEN', System.getenv("MAPBOX_ACCESS_TOKEN") | |||
| buildConfigField 'String', 'MAPBOX_ACCESS_TOKEN', project.hasProperty('MAPBOX_ACCESS_TOKEN') ? project.property('MAPBOX_ACCESS_TOKEN') : System.getenv('MAPBOX_ACCESS_TOKEN') | |||
| TRAFFIC_TENDENCY_RAPIDLY_INCREASING_CONGESTION, | ||
| TRAFFIC_TENDENCY_RAPIDLY_DECREASING_CONGESTION | ||
| }) | ||
| public @interface TrafficTendencyCriteria { |
There was a problem hiding this comment.
Is the annotation used anywhere?
There was a problem hiding this comment.
only in comments
This reverts commit 43bae13.
VysotskiVadim
force-pushed
the
vv-traffic-tendecy
branch
from
6079ba3
to
a35f833
Compare
Added. I only had doubts if I should mention new annotation in route options docs. I decided not to mention and not to add comments there |
dzinad
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a private API, so absence of documentation is expected.
This feature was already introduced in the past but then reverted: #1451