[WIP] Add roundaboutExits param to MapboxDirections #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added roundaboutExits param to MapboxDirections. Still need to add fixtures, test and check param description
ericrwolfe
reviewed
Sep 14, 2017
| * @return true it is possible to exit on the roundabout {@link #setRoundaboutExits(Boolean)}. | ||
| * @since 2.2.4 | ||
| */ | ||
| public Boolean isRoundaboutExits() { |
There was a problem hiding this comment.
Can we change this to something like allowsRoundaboutExits()?
ericrwolfe
reviewed
Sep 14, 2017
| @@ -591,6 +604,14 @@ public T setBaseUrl(String baseUrl) { | |||
| } | |||
|
|
|||
| /** | |||
| * @return true it is possible to exit on the roundabout {@link #setRoundaboutExits(Boolean)}. | |||
There was a problem hiding this comment.
A more descriptive doc for this given the below would be "return true if you enabled additional instructions while exiting rotaries and roundabouts."
ericrwolfe
reviewed
Sep 14, 2017
| @@ -373,6 +375,17 @@ public T setLanguage(String language) { | |||
| return (T) this; | |||
| } | |||
|
|
|||
| /** | |||
| * Optionally, call if you'd like to specify if exit on a roundabout is allowed. | |||
There was a problem hiding this comment.
"Optionally, set this to true if you want to enable instructions while exiting roundabouts and rotaries."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added roundaboutExits param to MapboxDirections.
Still need:
cc: @zugaldia @cammace