Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename BoundingBox.fromCoordinates() to BoundingBox.fromLngLats() #789

Merged
merged 1 commit into from
Apr 23, 2018
Merged

rename BoundingBox.fromCoordinates() to BoundingBox.fromLngLats() #789

merged 1 commit into from
Apr 23, 2018

Conversation

osana
Copy link
Contributor

@osana osana commented Apr 12, 2018

rename BoundingBox.fromCoordinates() to BoundingBox.fromLngLats()
for consistency with the rest of the API

closes #788

@osana osana requested a review from cammace April 12, 2018 19:05
cammace
cammace reviewed Apr 17, 2018
View reviewed changes
Copy link
Contributor

@cammace cammace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we've released the 3.0 final, this is an API breaking change, therefore, we simply need to @deprecate the fromCoordinates method and add additional methods for fromLngLat. Everything else looks good.

@osana osana force-pushed the osana-bb-getLngLats branch 2 times, most recently from fdbde4b to acb5fbf Compare April 18, 2018 03:50
@osana osana requested a review from cammace April 18, 2018 03:51
@osana osana merged commit fa905a9 into master Apr 23, 2018
@osana osana deleted the osana-bb-getLngLats branch April 23, 2018 14:19
@osana osana mentioned this pull request May 1, 2018
Closed
13 tasks
@langsmith langsmith mentioned this pull request May 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammace cammace cammace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BoundingBox.fromCoordinates() -> BoundingBox.fromLngLats()
2 participants
@osana @cammace