Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove waypoint limit check #928

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Remove waypoint limit check #928

merged 1 commit into from
Nov 30, 2018

Conversation

Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Nov 30, 2018 •
edited
Loading

  • Removes waypoint limit check - there is no such a limitation for offline routes (MapboxDirections is used to generate offline routes URLs). For online, we're still accounting for that because the Directions API will throw an error which is handled gracefully by MapboxDirections.

cc @osana

@Guardiola31337 Guardiola31337 self-assigned this Nov 30, 2018
danesfeder
danesfeder approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Guardiola31337 🚀

@Guardiola31337 Guardiola31337 merged commit 5218299 into master Nov 30, 2018
@Guardiola31337 Guardiola31337 deleted the pg-remove-waypoint-limit-check branch November 30, 2018 23:42
@Guardiola31337 Guardiola31337 mentioned this pull request Dec 1, 2018
Closed
12 tasks
osana
osana reviewed Dec 17, 2018
View reviewed changes
Copy link
Contributor

@osana osana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to modify/move tests instead of deleting them.
Directions have DirectionsError that would catch those.
Also gives customers and idea on how the Error is reported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osana osana osana left review comments

@danesfeder danesfeder danesfeder approved these changes

Assignees

@Guardiola31337 Guardiola31337

Labels
Directions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Guardiola31337 @danesfeder @osana