to improve performance: do not use BigDecimal for rounding #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osana
force-pushed
the
osana-rounding
branch
3 times, most recently
from
87326b3
to
d7ccecf
Compare
LukasPaczos
approved these changes
Dec 13, 2018
| * @return trimmed value | ||
| */ | ||
| public static double trim(double value) { | ||
| return Math.round(value * 10000000.0) / 10000000.0; |
There was a problem hiding this comment.
Can we do a check for infinity overflow here after multiplication and throw an exception if it occurs?
osana
force-pushed
the
osana-rounding
branch
from
d7ccecf
to
b4ead6e
Compare
LukasPaczos
approved these changes
Dec 13, 2018
This was referenced Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #932