removed AutoValue from geoJson #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osana
force-pushed
the
osana-remove-autovalue
branch
from
d517acb
to
7bf6116
Compare
osana
force-pushed
the
osana-remove-autovalue
branch
7 times, most recently
from
0be9ee7
to
e408e19
Compare
osana
force-pushed
the
osana-remove-autovalue
branch
4 times, most recently
from
a65ac1e
to
17b3b63
Compare
tobrun
approved these changes
Feb 11, 2019
LukasPaczos
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
Looks good!
I had a bunch of nitpicks lined up like code styling or suppressing non-existent warnings, but those should get caught with an improved checkstyle and not block this PR. We should try and merge these changes as soon as possible so that we can fully test them as a part of the upcoming Maps SDK v7.3.0 release train.
| protected List<Double> readPointList(JsonReader in) throws IOException { | ||
|
|
||
| if (in.peek() == JsonToken.NULL) { | ||
| throw new NullPointerException(); |
There was a problem hiding this comment.
Can we return null here to print a more detailed from the calling method?
services-geojson/src/main/java/com/mapbox/geojson/BaseGeometryTypeAdapter.java
Show resolved
Hide resolved
| this.boundingBoxAdapter = new BoundingBoxTypeAdapter(); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") |
There was a problem hiding this comment.
There's no warning to suppress.
| } | ||
|
|
||
| @Override | ||
| @SuppressWarnings("unchecked") |
| } | ||
|
|
||
| @Override | ||
| @SuppressWarnings("unchecked") |
| } | ||
|
|
||
| @Override | ||
| @SuppressWarnings("unchecked") |
| } | ||
|
|
||
| @Override | ||
| @SuppressWarnings("unchecked") |
| } | ||
|
|
||
| @Override | ||
| @SuppressWarnings("unchecked") |
| /** | ||
| * Adapter to read and write coordinates for Point class. | ||
| * | ||
| * @since 4.1.0 |
| import java.util.List; | ||
|
|
||
| /** | ||
| * Adapter to read and write coordinates for Point class. |
There was a problem hiding this comment.
This should mention BoundingBox class.
added 2 commits
March 4, 2019 13:28
BoundingBoxDeserializer and BoundingBoxSerializer, GeometryDeserializer in favor of TypeAdapters
osana
force-pushed
the
osana-remove-autovalue
branch
from
17b3b63
to
c293b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #710