Address review comments.

mapbox · Nov 3, 2022 · 5b29680 · 5b29680
1 parent 72c73bc
commit 5b29680
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/sdk/src/main/java/com/mapbox/maps/MapController.kt b/sdk/src/main/java/com/mapbox/maps/MapController.kt
@@ -219,12 +219,16 @@ internal class MapController : MapPluginProviderDelegate, MapControllable {
 
   override fun addWidget(widget: Widget) {
     val weakThis = WeakReference(this)
-    renderer.renderThread.addWidget(widget.also { it.setRepaintTrigger { weakThis.get()?.renderer?.scheduleRepaint() } })
+    widget.setRepaintTrigger {
+      weakThis.get()?.renderer?.scheduleRepaint()
+    }
+    renderer.renderThread.addWidget(widget)
     renderer.scheduleRepaint()
   }
 
   override fun removeWidget(widget: Widget): Boolean {
     val wasRemoved = renderer.renderThread.removeWidget(widget)
+    widget.setRepaintTrigger(null)
     if (wasRemoved) {
       renderer.scheduleRepaint()
     }

diff --git a/sdk/src/main/java/com/mapbox/maps/renderer/widget/Widget.kt b/sdk/src/main/java/com/mapbox/maps/renderer/widget/Widget.kt
@@ -8,14 +8,14 @@ import com.mapbox.maps.MapboxExperimental
 @MapboxExperimental
 abstract class Widget internal constructor() {
   internal abstract val renderer: WidgetRenderer
-  private var repaintTriggerWeakReference: (() -> Unit)? = null
+  private var repaintTrigger: (() -> Unit)? = null
 
   /**
    * Triggers a repaint of the widget, as well as the map.
    * It will do nothing if the widget has not been added to the map.
    */
   protected fun triggerRepaint() {
-    repaintTriggerWeakReference?.invoke()
+    repaintTrigger?.invoke()
   }
 
   /**
@@ -51,7 +51,7 @@ abstract class Widget internal constructor() {
   abstract fun getRotation(): Float
 
   @JvmSynthetic
-  internal fun setRepaintTrigger(trigger: () -> Unit) {
-    repaintTriggerWeakReference = trigger
+  internal fun setRepaintTrigger(trigger: (() -> Unit)?) {
+    repaintTrigger = trigger
   }
 }