Skip to content

Commit

Permalink
Address review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
pengdev committed Nov 3, 2022
1 parent ee73447 commit f37490b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sdk/src/main/java/com/mapbox/maps/MapController.kt
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ internal class MapController : MapPluginProviderDelegate, MapControllable {

override fun removeWidget(widget: Widget): Boolean {
val wasRemoved = renderer.renderThread.removeWidget(widget)
widget.setRepaintTrigger(null)
if (wasRemoved) {
widget.setRepaintTrigger(null)
renderer.scheduleRepaint()
}
return wasRemoved
Expand Down
4 changes: 2 additions & 2 deletions sdk/src/main/java/com/mapbox/maps/renderer/widget/Widget.kt
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ abstract class Widget internal constructor() {
abstract fun getRotation(): Float

@JvmSynthetic
internal fun setRepaintTrigger(trigger: (() -> Unit)?) {
repaintTrigger = trigger
internal fun setRepaintTrigger(doOnRepaint: (() -> Unit)?) {
repaintTrigger = doOnRepaint
}
}

0 comments on commit f37490b

Please sign in to comment.