Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] dispatchTelemetryTurnstileEvent on main thread #1643

Open
florianPOLARSTEPS opened this issue Sep 2, 2022 · 0 comments
Open
Labels
bug 🪲 Something isn't working

Comments

@florianPOLARSTEPS
Copy link

Environment

  • Android OS version: any
  • Devices affected: any
  • Maps SDK Version: 10.7.x - 10.8.x (but probably more)

Observed behavior and steps to reproduce

I have been doing some benchmarking of startup times for my screens that contain mapbox maps, and found that a significant portion of startup time comes from firing Turnstile events during mapcontroller startup.

I guess it's necessary to do those things, but do they really have to run on the main thread?
Screenshot 2022-09-02 at 09 48 19

Expected behavior

Better startup performance of the map.

Notes / preliminary analysis

If you look at the screenshot of the CPU trace from Android studio, a lot of it comes from just reading the phone state (network info) from the system. I do not believe any of those system calls need to happen on the UI thread.

@florianPOLARSTEPS florianPOLARSTEPS added the bug 🪲 Something isn't working label Sep 2, 2022
mapbox-github-ci-writer-public-1 bot pushed a commit that referenced this issue Apr 20, 2023
* Fix old CircleCI parameter usage in reporting commands.

* Fix flacky geojson test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant