Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera twitches if moved during ongoing animation #596

Closed
zeac opened this issue Aug 30, 2021 · 0 comments · Fixed by #597
Closed

Camera twitches if moved during ongoing animation #596

zeac opened this issue Aug 30, 2021 · 0 comments · Fixed by #597
Assignees
@zeac
Labels
bug 🪲 Something isn't working p1

Comments

@zeac
Copy link
Contributor

zeac commented Aug 30, 2021

Environment

  • Android OS version: Android 6
  • Devices affected: Emulator
  • Maps SDK Version: android-v10.0.0-rc.7

Observed behavior and steps to reproduce

Maps SDK allows to start an animation that is not canceled if user interacts with the map.
It works well on Android 7+, but there is an issue on Android 6 captured on the attached video.

bug.mp4

Notes / preliminary analysis

The root of problem in the ValueAnimator callbacks order again.
@zeac zeac added the bug 🪲 Something isn't working label Aug 30, 2021
zeac added a commit that referenced this issue Aug 30, 2021
@zeac
#596: [testapp] Add OngoingAnimationActivity sample.
fe06e48
zeac added a commit that referenced this issue Aug 30, 2021
@zeac
#596: Remove callback order dependency from CameraAnimationsPluginImpl
b8aa498
@zeac zeac mentioned this issue Aug 30, 2021
Merged
7 tasks
zeac added a commit that referenced this issue Aug 30, 2021
@zeac
#596: [testapp] Add OngoingAnimationActivity sample.
0956fea
zeac added a commit that referenced this issue Aug 30, 2021
@zeac
#596: Remove callback order dependency from CameraAnimationsPluginImpl
5fc6d28
zeac added a commit that referenced this issue Aug 30, 2021
@zeac
#596: Remove callback order dependency from CameraAnimationsPluginImpl
d2fcedb
@tyofemi tyofemi added p1 and removed p1 labels Aug 30, 2021
zeac added a commit that referenced this issue Aug 31, 2021
@zeac
#596: Remove callback order dependency from CameraAnimationsPluginImpl
0a6b462
zeac added a commit that referenced this issue Aug 31, 2021
@zeac
#596: Remove callback order dependency from CameraAnimationsPluginImpl
6a454d7
zeac added a commit that referenced this issue Aug 31, 2021
@zeac
#596: Remove callback order dependency from CameraAnimationsPluginImpl
2ef792e
@knov knov added the p2 label Aug 31, 2021
zeac added a commit that referenced this issue Aug 31, 2021
@zeac
#596: Remove callback order dependency from CameraAnimationsPluginImpl
4508752
zeac added a commit that referenced this issue Sep 1, 2021
@zeac
#596: Remove callback order dependency from CameraAnimationsPluginImpl
2e5e990
zeac added a commit that referenced this issue Sep 6, 2021
@zeac
#596: [testapp] Add OngoingAnimationActivity sample.
b07e24d
zeac added a commit that referenced this issue Sep 6, 2021
@zeac
#596: Remove callback order dependency from CameraAnimationsPluginImpl
120568e
@kiryldz kiryldz added p1 and removed p2 labels Sep 6, 2021
@Chaoba Chaoba assigned zeac and unassigned Chaoba and ank27 Sep 6, 2021
@zeac zeac closed this as completed in #597 Sep 6, 2021
zeac added a commit that referenced this issue Sep 6, 2021
@zeac
Fix camera animators ordering on Android 6 and lower (#597)
ceeaed8 
#596: Remove callback order dependency from CameraAnimationsPluginImpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeac zeac

Labels
bug 🪲 Something isn't working p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix camera animators ordering on Android 6 and lower mapbox/mapbox-maps-android
6 participants
@zeac @knov @Chaoba @ank27 @kiryldz @tyofemi