Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android auto extension #1004

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Conversation

kmadsen
Copy link
Contributor

@kmadsen kmadsen commented Dec 17, 2021

Summary of changes

Introduces three public classes for customizing and interacting with Mapbox Maps with Android Auto supported head units.

  1. MapboxCarMap is a registry for MapboxCarMapObserver. Constructing this object will add mapbox map to the head unit. Registering observers allows you to make build customizations for the MapboxMap.
  2. MapboxCarMapObserver is a lifecycle aware interface for attaching and detaching map experiences.
  3. MapboxCarMapSurface is a data transport object for the car surface and mapbox map

This is porting over an android auto map solution from navigation, with a few updates. The MapboxCarOptions have been removed in favor of only using MapInitOptions. The comments and tests are also updated to fit in better with the mapbox-maps-android repository.

android-auto-map.mov

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Introduces experimental apis for integrating android auto. MapboxCarMapandMapboxCarMapObserver.</changelog>.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@kmadsen kmadsen force-pushed the km-update-android-auto-extension branch 6 times, most recently from d7b2809 to 56540f9 Compare December 20, 2021 19:09
@kmadsen kmadsen force-pushed the km-update-android-auto-extension branch 8 times, most recently from 44feb17 to 5b4d16d Compare December 20, 2021 22:03
@kmadsen kmadsen force-pushed the km-update-android-auto-extension branch from 5b4d16d to b1ab452 Compare January 10, 2022 19:05
@kmadsen kmadsen force-pushed the km-update-android-auto-extension branch 2 times, most recently from 09b1320 to 21a7894 Compare January 18, 2022 20:10
@kmadsen kmadsen marked this pull request as ready for review January 18, 2022 20:45
@kmadsen kmadsen requested a review from a team as a code owner January 18, 2022 20:45
.circleci/config.yml Outdated Show resolved Hide resolved
@kmadsen kmadsen force-pushed the km-update-android-auto-extension branch 2 times, most recently from fea1416 to b38ffba Compare January 20, 2022 17:56
@kmadsen kmadsen force-pushed the km-update-android-auto-extension branch 3 times, most recently from 5b4d7d3 to 5a0efc5 Compare February 8, 2022 00:39
@yunikkk yunikkk mentioned this pull request Feb 9, 2022
@kmadsen kmadsen force-pushed the km-update-android-auto-extension branch 3 times, most recently from 7cdc98b to bf6d182 Compare February 10, 2022 23:11
@kmadsen kmadsen force-pushed the km-update-android-auto-extension branch 2 times, most recently from 83c1e73 to fc0d002 Compare February 14, 2022 18:40
@kmadsen kmadsen force-pushed the km-update-android-auto-extension branch from fc0d002 to faecd16 Compare February 14, 2022 18:42
@kmadsen kmadsen force-pushed the km-update-android-auto-extension branch from faecd16 to fe78793 Compare February 14, 2022 18:48
@kmadsen
Copy link
Contributor Author

kmadsen commented Feb 14, 2022

Rebased so now there are widgets! See compass and logo

Screen Shot 2022-02-14 at 10 54 14 AM

Screen Shot 2022-02-14 at 10 54 28 AM

@kmadsen kmadsen merged commit db43105 into main Feb 14, 2022
@kmadsen kmadsen deleted the km-update-android-auto-extension branch February 14, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants