-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update android auto extension #1004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmadsen
force-pushed
the
km-update-android-auto-extension
branch
6 times, most recently
from
December 20, 2021 19:09
d7b2809
to
56540f9
Compare
kmadsen
commented
Dec 20, 2021
kmadsen
force-pushed
the
km-update-android-auto-extension
branch
8 times, most recently
from
December 20, 2021 22:03
44feb17
to
5b4d16d
Compare
kmadsen
force-pushed
the
km-update-android-auto-extension
branch
from
January 10, 2022 19:05
5b4d16d
to
b1ab452
Compare
kmadsen
force-pushed
the
km-update-android-auto-extension
branch
2 times, most recently
from
January 18, 2022 20:10
09b1320
to
21a7894
Compare
pengdev
reviewed
Jan 19, 2022
pengdev
reviewed
Jan 19, 2022
pengdev
reviewed
Jan 19, 2022
pengdev
reviewed
Jan 19, 2022
android-auto-app/src/main/java/com/mapbox/maps/testapp/auto/car/CarCameraController.kt
Outdated
Show resolved
Hide resolved
pengdev
reviewed
Jan 19, 2022
pengdev
reviewed
Jan 19, 2022
pengdev
reviewed
Jan 19, 2022
...n-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/CarMapLifecycleObserver.kt
Outdated
Show resolved
Hide resolved
kmadsen
force-pushed
the
km-update-android-auto-extension
branch
2 times, most recently
from
January 20, 2022 17:56
fea1416
to
b38ffba
Compare
yunikkk
approved these changes
Feb 7, 2022
pengdev
reviewed
Feb 7, 2022
...sion-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/MapboxCarMapObserver.kt
Show resolved
Hide resolved
pengdev
reviewed
Feb 7, 2022
...sion-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/MapboxCarMapObserver.kt
Show resolved
Hide resolved
pengdev
reviewed
Feb 7, 2022
android-auto-app/src/main/java/com/mapbox/maps/testapp/auto/car/CarJavaInterfaceChecker.java
Show resolved
Hide resolved
pengdev
reviewed
Feb 7, 2022
pengdev
reviewed
Feb 7, 2022
android-auto-app/src/main/java/com/mapbox/maps/testapp/auto/car/MapSession.kt
Show resolved
Hide resolved
pengdev
reviewed
Feb 7, 2022
pengdev
reviewed
Feb 7, 2022
extension-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/MapboxCarMap.kt
Outdated
Show resolved
Hide resolved
pengdev
reviewed
Feb 7, 2022
...nsion-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/MapboxCarMapSurface.kt
Show resolved
Hide resolved
pengdev
reviewed
Feb 7, 2022
...ion-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/CarMapSurfaceCallback.kt
Show resolved
Hide resolved
pengdev
reviewed
Feb 7, 2022
extension-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/MapboxCarMap.kt
Show resolved
Hide resolved
pengdev
reviewed
Feb 7, 2022
...ion-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/CarMapSurfaceCallback.kt
Show resolved
Hide resolved
kmadsen
force-pushed
the
km-update-android-auto-extension
branch
3 times, most recently
from
February 8, 2022 00:39
5b4d7d3
to
5a0efc5
Compare
Merged
kmadsen
force-pushed
the
km-update-android-auto-extension
branch
3 times, most recently
from
February 10, 2022 23:11
7cdc98b
to
bf6d182
Compare
kmadsen
force-pushed
the
km-update-android-auto-extension
branch
2 times, most recently
from
February 14, 2022 18:40
83c1e73
to
fc0d002
Compare
pengdev
approved these changes
Feb 14, 2022
kmadsen
force-pushed
the
km-update-android-auto-extension
branch
from
February 14, 2022 18:42
fc0d002
to
faecd16
Compare
kmadsen
force-pushed
the
km-update-android-auto-extension
branch
from
February 14, 2022 18:48
faecd16
to
fe78793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Introduces three public classes for customizing and interacting with Mapbox Maps with Android Auto supported head units.
MapboxCarMap
is a registry forMapboxCarMapObserver
. Constructing this object will add mapbox map to the head unit. Registering observers allows you to make build customizations for theMapboxMap
.MapboxCarMapObserver
is a lifecycle aware interface for attaching and detaching map experiences.MapboxCarMapSurface
is a data transport object for the car surface and mapbox mapThis is porting over an android auto map solution from navigation, with a few updates. The MapboxCarOptions have been removed in favor of only using
MapInitOptions
. The comments and tests are also updated to fit in better with the mapbox-maps-android repository.android-auto-map.mov
User impact (optional)
Pull request checklist:
@JvmOverloads
,@file:JvmName
, etc).mapbox-maps-android
changelog:<changelog>Introduces experimental apis for integrating android auto.
MapboxCarMapand
MapboxCarMapObserver.</changelog>
.v10.[version]
release branch fix / enhancement, merge it tomain
firstly and then port tov10.[version]
release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.