Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V10.3 port: Fix map not rendering on emulators when MSAA is enabled #1086

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

kiryldz
Copy link
Contributor

@kiryldz kiryldz commented Jan 26, 2022

Summary of changes

At least Google simulators seem not to support MSAA option when configuring EGL. This will result in map not being rendered at all. Now logic is introduced to try double down EGL_SAMPLE value in a loop until either supported MSAA config will be found (fixing an issue of map not being rendered even on physical device when setting huge MSAA value) or EGL will be configured without MSAA (fixing an issue with emulators).

Port for #1077

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Fix map not rendering on emulators when MSAA is enabled.</changelog>.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@kiryldz kiryldz requested a review from a team January 26, 2022 11:46
@kiryldz kiryldz self-assigned this Jan 26, 2022
@kiryldz kiryldz merged commit 7d9ad17 into v10.3 Jan 26, 2022
@kiryldz kiryldz deleted the v10.3_port_kdz-fix-msaa-emulators branch January 26, 2022 11:49
@kiryldz kiryldz added the bug 🪲 Something isn't working label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants