Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependencies] Bump gl-native to v10.3.1 #1116

Merged
merged 1 commit into from
Feb 8, 2022
Merged

[Dependencies] Bump gl-native to v10.3.1 #1116

merged 1 commit into from
Feb 8, 2022

Conversation

ank27
Copy link
Contributor

@ank27 ank27 commented Feb 3, 2022 •
edited
Loading

This PR updates gl-native to v10.3.1

Bug fixes 🐞

  • Avoid possible crash at program exit caused by dummy tracer accessed after destruction. (#1116)
  • Fix crash for the case when a map event is handled by an Observer of a destructed map. (#1116 )

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Update gl-native to 10.3.1</changelog>.
  • If this PR is a v10.3 release branch fix / enhancement, merge it to main firstly and then port to v10.3 release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@ank27 ank27 added the dependencies Pull requests that update a dependency file label Feb 3, 2022
@ank27 ank27 requested a review from a team as a code owner February 3, 2022 16:38
@ank27 ank27 self-assigned this Feb 3, 2022
@kiryldz
Copy link
Contributor

kiryldz commented Feb 4, 2022

@ank27 changelog looks pretty strange, seems to be missing all rc.1 entries, guess this PR is a good place to also add them here.
image

@ank27
Copy link
Contributor Author

ank27 commented Feb 4, 2022

@ank27 changelog looks pretty strange, seems to be missing all rc.1 entries, guess this PR is a good place to also add them here. image

Yeah, these are public-facing changelogs from dependencies bump. I haven't added rc, beta changes yet. I will do that with release process.

pengdev
pengdev reviewed Feb 4, 2022
View reviewed changes
CHANGELOG.md
@@ -12,8 +12,35 @@ Mapbox welcomes participation and contributions from everyone.

# 10.3.0 February 7, 2022

## Features ✨ and improvements 🏁
* Improve performance for symbol layout rendering in continuous mode. ([#1105](https://github.com/mapbox/mapbox-maps-android/pull/1105))
* Introduce metadata setter API for the legacy offline region. ([#1105](https://github.com/mapbox/mapbox-maps-android/pull/1105))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was introduced in https://github.com/mapbox/mapbox-maps-android/releases/tag/android-v10.3.0-rc.1, do we want to state it again in the v10.3.0 changelog?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pengdev AFAIR we state delta of changes between last stable release for the stable release. So we should have all the changes here since v10.2.0 letting majority users easily migrate between stable versions.

@ank27 ank27 changed the title bump gl-native to v10.3.1 [Dependencies] Bump gl-native to v10.3.1 Feb 7, 2022
@ank27 ank27 requested review from pengdev and kiryldz February 8, 2022 12:07
kiryldz
kiryldz approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I see the point now - with this PR we add public gl-native changelog entries from gl-native version v10.2.0 till v10.3.1. On the other hand I guess those entries should have already all been there except:

* Avoid possible crash at program exit caused by dummy tracer accessed after destruction. ([#1116](https://github.com/mapbox/mapbox-maps-android/pull/1116))
* Fix crash for the case when a map event is handled by an Observer of a destructed map. ([#1116](https://github.com/mapbox/mapbox-maps-android/pull/1116))

In any case, LGTM, we will append our changelog (add Android SDK related entries) a bit later when cutting a release.

@ank27 ank27 merged commit 81b1b0a into main Feb 8, 2022
@ank27 ank27 deleted the ak-bump-gl-native-10.3.1 branch February 8, 2022 14:30
ank27 added a commit that referenced this pull request Feb 8, 2022
@ank27
bump gl-native deps (#1116)
3fd5b9c
ank27 added a commit that referenced this pull request Feb 8, 2022
@ank27
[port] bump gl-native to 10.3.1, common to v21.1.0 (#1130)
2d0caff 
* [deps] Bump gl-native to v10.3.0, common to v21.1.0 (#1105)

* update dependencies

* update changelog.md

* bump gl-native deps (#1116)
@kiryldz kiryldz mentioned this pull request Feb 9, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunikkk yunikkk yunikkk approved these changes

@kiryldz kiryldz kiryldz approved these changes

@pengdev pengdev Awaiting requested review from pengdev

Assignees

@ank27 ank27

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ank27 @kiryldz @yunikkk @pengdev