Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LocationCompassEngine for location component #1131

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Feb 9, 2022

Summary of changes

This PR adds the location compass with interface2.

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog></changelog>.
  • If this PR is a v10.4 release branch fix / enhancement, merge it to main firstly and then port to v10.4 release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

CHANGELOG.md Show resolved Hide resolved
@Chaoba Chaoba requested a review from yunikkk February 11, 2022 12:00
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Chaoba Chaoba requested a review from kiryldz February 14, 2022 08:38
CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@pengdev pengdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

@Chaoba Chaoba merged commit 9d5a590 into main Feb 15, 2022
@Chaoba Chaoba deleted the kl-location-compass branch February 15, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants