-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LocationCompassEngine for location component #1131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaoba
force-pushed
the
kl-location-compass
branch
from
February 9, 2022 07:40
abd710a
to
0089429
Compare
...ioncomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationCompassEngine.kt
Outdated
Show resolved
Hide resolved
...ioncomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationCompassEngine.kt
Outdated
Show resolved
Hide resolved
...ioncomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationCompassEngine.kt
Outdated
Show resolved
Hide resolved
...omponent/src/test/java/com/mapbox/maps/plugin/locationcomponent/LocationCompassEngineTest.kt
Show resolved
Hide resolved
yunikkk
reviewed
Feb 9, 2022
...ponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationComponentPluginImpl.kt
Outdated
Show resolved
Hide resolved
Chaoba
force-pushed
the
kl-location-compass
branch
from
February 10, 2022 03:16
0089429
to
c2722ec
Compare
Chaoba
force-pushed
the
kl-location-compass
branch
from
February 10, 2022 08:40
c2722ec
to
c158820
Compare
yunikkk
reviewed
Feb 10, 2022
yunikkk
reviewed
Feb 10, 2022
kiryldz
reviewed
Feb 11, 2022
...src/test/java/com/mapbox/maps/plugin/attribution/generated/AttributionAttributeParserTest.kt
Show resolved
Hide resolved
kiryldz
reviewed
Feb 11, 2022
...compass/src/test/java/com/mapbox/maps/plugin/compass/generated/CompassAttributeParserTest.kt
Show resolved
Hide resolved
kiryldz
reviewed
Feb 11, 2022
...tures/src/test/java/com/mapbox/maps/plugin/gestures/generated/GesturesAttributeParserTest.kt
Show resolved
Hide resolved
kiryldz
reviewed
Feb 11, 2022
...ain/java/com/mapbox/maps/plugin/locationcomponent/generated/LocationComponentSettingsBase.kt
Outdated
Show resolved
Hide resolved
kiryldz
reviewed
Feb 11, 2022
...lebar/src/test/java/com/mapbox/maps/plugin/scalebar/generated/ScaleBarAttributeParserTest.kt
Show resolved
Hide resolved
kiryldz
reviewed
Feb 11, 2022
plugin-logo/src/test/java/com/mapbox/maps/plugin/logo/generated/LogoAttributeParserTest.kt
Show resolved
Hide resolved
pengdev
reviewed
Feb 11, 2022
pengdev
reviewed
Feb 11, 2022
yunikkk
approved these changes
Feb 11, 2022
Chaoba
force-pushed
the
kl-location-compass
branch
from
February 14, 2022 03:29
c158820
to
245c526
Compare
kiryldz
reviewed
Feb 14, 2022
kiryldz
reviewed
Feb 14, 2022
Chaoba
force-pushed
the
kl-location-compass
branch
from
February 14, 2022 10:48
bea054b
to
e0adde6
Compare
pengdev
reviewed
Feb 14, 2022
...ioncomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationCompassEngine.kt
Show resolved
Hide resolved
pengdev
reviewed
Feb 14, 2022
app/src/main/java/com/mapbox/maps/testapp/examples/LocationComponentActivity.kt
Outdated
Show resolved
Hide resolved
pengdev
reviewed
Feb 14, 2022
app/src/main/java/com/mapbox/maps/testapp/examples/LocationComponentActivity.kt
Outdated
Show resolved
Hide resolved
pengdev
reviewed
Feb 14, 2022
Chaoba
force-pushed
the
kl-location-compass
branch
from
February 14, 2022 14:15
e0adde6
to
ee52e84
Compare
pengdev
reviewed
Feb 14, 2022
pengdev
reviewed
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nit
pengdev
approved these changes
Feb 14, 2022
Chaoba
force-pushed
the
kl-location-compass
branch
from
February 14, 2022 14:48
26fb41e
to
f4c128f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR adds the location compass with interface2.
User impact (optional)
Pull request checklist:
@JvmOverloads
,@file:JvmName
, etc).mapbox-maps-android
changelog:<changelog></changelog>
.v10.4
release branch fix / enhancement, merge it tomain
firstly and then port tov10.4
release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.