[viewport] Refinements to public API documentation. #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengdev
force-pushed
the
peng-improve-viewport-apidoc
branch
from
b40463d
to
b10462f
Compare
kiryldz
reviewed
Feb 10, 2022
sdk-base/src/main/java/com/mapbox/maps/plugin/viewport/ViewportPlugin.kt
Show resolved
Hide resolved
kiryldz
reviewed
Feb 10, 2022
sdk-base/src/main/java/com/mapbox/maps/plugin/viewport/data/OverviewViewportStateOptions.kt
Outdated
Show resolved
Hide resolved
ank27
approved these changes
Feb 10, 2022
pengdev
added a commit
that referenced
this pull request
Feb 10, 2022
* [viewport] Refinements to public API documentation. * Address review comments.
9 tasks
pengdev
added a commit
that referenced
this pull request
Feb 10, 2022
* [viewport] Refinements to public API documentation. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR refines the public API documentation for viewport plugin, and align with iOS API docs.
User impact (optional)
Pull request checklist:
@JvmOverloads,@file:JvmName, etc).mapbox-maps-androidchangelog:<changelog></changelog>.v10.[version]release branch fix / enhancement, merge it tomainfirstly and then port tov10.[version]release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.