-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add map function to apply style transition during style load #1174
Conversation
Since we apply |
Previously it was not applied at all but yes, I did even state in docs that user could set it once - and it will be applied to all style loads happening afterwards. |
19bbb28
to
a0b84c7
Compare
@ank27 correction after deeper look - we do actually reset transition options for the next style, it's reflected in code now, PTAL |
a0b84c7
to
942a337
Compare
57da439
to
e9b5878
Compare
e9b5878
to
e3b7264
Compare
app/src/main/java/com/mapbox/maps/testapp/examples/CircleLayerClusteringActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 nit
app/src/main/java/com/mapbox/maps/testapp/examples/CircleLayerClusteringActivity.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nits
07bc042
to
f472f4e
Compare
Summary of changes
Introduce new function
MapboxMap.setStyleTransition
and deprecateStyle.setStyleTransition
.Main idea is that we need to apply transition options in the correct moment of time during style is loading while our current API allows to actually operate on
Style
object when style is already fully loaded.Please take a look at the visuals, what we do there is:
TransitionOptions.Builder().duration(0).build()
TransitionOptions.Builder().duration(5000).delay(3000).build()
User impact (optional)
Following pseudo-code:
should be replaced with:
Pull request checklist:
incorrect.mp4
correct.mp4
@JvmOverloads
,@file:JvmName
, etc)../gradlew apiDump
to update generated api files, if there's public API changes, otherwise theverify-kotlin-binary-compatibility
CI will fail.mapbox-maps-android
changelog:<changelog>Add overloaded MapboxMap.loadStyleUri, MapboxMap.loadStyleJson, MapboxMap.loadStyle with
TransitionOptionsparameter allowing to apply transition style being loaded.</changelog>
.v10.[version]
release branch fix / enhancement, merge it tomain
firstly and then port tov10.[version]
release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.