[Deps] Bump gl native 10.4.0 beta.2

[ank27]

Summary of changes

Bump gl-native to 10.4.0-beta.2
Revert common.so changes.

User impact (optional)

Pull request checklist:

• Briefly describe the changes in this PR.
• Include before/after visuals or gifs if this PR includes visual changes.
• Write tests for all new functionality. If tests were not written, please explain why.
• Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
• Add example if relevant.
• Document any changes to public APIs.
• Run ./gradlew apiDump to update generated api files, if there's public API changes, otherwise the verify-kotlin-binary-compatibility CI will fail.
• Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
• Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog></changelog>.
• If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

[Chaoba]

We still need it when build from source

[Chaoba]

The same here

[Chaoba]

The same here

[kiryldz]

@Chaoba with previous gradle plugin it was more of an AGP bug that so from previous build was not cleared properly leading to duplicate error. Cleaning build directories fixed that. If that issue is fixed with new gradle plugin - we indeed do not need it here I guess.
@ank27 any more comments here?

[ank27]

Yes correct, and since gl-native exclude common.so as well, we don't need this here.

[pengdev]

the common.so could be duplicated when building from source, and it was

if (buildFromSource.toBoolean()) {
    packagingOptions {
      pickFirst("**/libc++_shared.so")
      pickFirst("**/libmapbox-common.so")
    }
  }
}

before the v10.4.0-beta.1 bump, we should probably move jniLibs.pickFirsts.add("**/libmapbox-common.so") to the if (buildFromSource.toBoolean()) closure.

[kiryldz]

@pengdev as I've described here those conditions were related to an issue in older AGP and could be fixed locally by cleaning previous build files. IMO we should remove it from end application gradle files to see if issue is resolved now and even if it's not - AFAIR we have a step in build from source section noting to call make clean before building from source. If we leave it - we may simply hide some error.

[ank27]

Earlier releases of gl-native did not exclude common.so explicitly from packagingOptions, i guess that's why pickFirst was added in the above config. If i understand correctly even building from source, the libs files are packaged as per packaginOptions in gradle. since now we exclude common.so from package with 10.4.0-beta.2, it shouldn't matter if we pickFirst in the config above. But we can keep it just be sure, wdyt? 🤔

[pengdev]

we can remove it and if we encounter issues while building from source, we add it back 🙂 Better to verify build from source first.

[ank27]

we can remove it and if we encounter issues while building from source, we add it back 🙂 Better to verify build from source first.

Attached internal ticket points to this pr which has buildFromSource passed. I think that would be fine to verify this behaviour?

[kiryldz]

@ank27 do we need that by the way? I was under an impression that gl-native does not contain libc++_shared and only common does and in that case we don't need pick first

[ank27]

Technically we don't need this as well, since only common adds this and gl-native exclude it. But I guess we can keep it the same as before.
Also, I don't know if any other project builds libc++_shared.so file, why was this added in the first place?

[pengdev]

This is used for building from source, where I think gl-native indeed will bundle the libc++_shared.so when built from source, we could verify it by building the project from source.