Deprecate FollowPuckViewportStateOptions.animationDurationMs. #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ank27
reviewed
Apr 4, 2022
ank27
approved these changes
Apr 4, 2022
Co-authored-by: Ankur Khandelwal <ankur.khandelwal@mapbox.com>
alexander-kulikovskii
approved these changes
Apr 5, 2022
kiryldz
reviewed
Apr 5, 2022
| @@ -60,6 +60,7 @@ class FollowPuckViewportStateOptions private constructor( | |||
| * | |||
| * Defaults to [DEFAULT_STATE_ANIMATION_DURATION_MS] milliseconds | |||
| */ | |||
| @Deprecated("AnimationDurationMs is not needed any more, the transition will be handled properly internally.") | |||
There was a problem hiding this comment.
I assume internally it's not handled for now - that's why we can't drop it right now, correct?
There was a problem hiding this comment.
yes, the actual fix will land in rc.1, we don't want to rush the fix itself, Deprecate affects public API, so that's why we add the Deprecated in beta.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR deprecates
FollowPuckViewportStateOptions.animationDurationMs, the transition will will handled properly by the Viewport plugin internally.User impact (optional)
Pull request checklist:
@JvmOverloads,@file:JvmName, etc).make update-apito update generated api files, if there's public API changes, otherwise theverify-api-*CI steps might fail.check changelogCI step will fail.v10.[version]release branch fix / enhancement, merge it tomainfirstly and then port tov10.[version]release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.