Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[viewport] Fix camera jump when default transition is canceled. #1262

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented Apr 6, 2022

Summary of changes

This PR fixes the camera jump issue when default transition is canceled.

User impact (optional)

Before After
screen-20220406-182512.mp4
screen-20220406-182432.mp4

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@pengdev pengdev added the bug 🪲 Something isn't working label Apr 6, 2022
@pengdev pengdev requested a review from a team as a code owner April 6, 2022 15:27
@pengdev pengdev self-assigned this Apr 6, 2022
@pengdev pengdev force-pushed the peng-fix-cancel-transition branch from 7b41c98 to 963a260 Compare April 6, 2022 15:29
@pengdev pengdev merged commit 05bc7a1 into main Apr 6, 2022
@pengdev pengdev deleted the peng-fix-cancel-transition branch April 6, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants