Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix geojson missing updates with persistent layer after style change #1324

Merged
merged 2 commits into from
May 5, 2022

Conversation

kiryldz
Copy link
Contributor

@kiryldz kiryldz commented May 5, 2022

Summary of changes

Due to nulling delegate explicitly when Style is not valid anymore we faced the situation that geojson updates were skipped after style was changed but only when using persistent layers. Now that's fixed and also as the temp solution we do not write warnings for using invalid style object in order not to confuse the users - this will be revisited later as it requires a bit deeper thinking how to treat style object when using persistent layers.

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@kiryldz kiryldz self-assigned this May 5, 2022
@kiryldz kiryldz requested a review from a team as a code owner May 5, 2022 10:06
@kiryldz kiryldz changed the title Fix geojson updates with persistent layer after style change Fix geojson missing updates with persistent layer after style change May 5, 2022
@kiryldz kiryldz added the bug 🪲 Something isn't working label May 5, 2022
@pengdev
Copy link
Member

pengdev commented May 5, 2022

@kiryldz could you double check the cases for other style extension high level abstractions like layer and terrain/light?

@kiryldz
Copy link
Contributor Author

kiryldz commented May 5, 2022

@kiryldz could you double check the cases for other style extension high level abstractions like layer and terrain/light?

Other style abstractions where not touched. GeoJson source is the only placed where we added that as it uses async parsing.

@kiryldz kiryldz merged commit 0aacc5d into main May 5, 2022
@kiryldz kiryldz deleted the kdz-fix-persistent-layer-update-style-change branch May 5, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants