Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing transition properties for atmosphere and terrain #1451

Conversation

kiryldz
Copy link
Contributor

@kiryldz kiryldz commented Jun 23, 2022

Summary of changes

Following properties have been added:

  1. Atmosphere:
  • colorTransition
  • highColorTransition
  • horizonBlendTransition
  • rangeTransition
  • spaceColorTransition
  • starIntensityTransition
  1. Terrain:
  • exaggerationTransition

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@kiryldz kiryldz self-assigned this Jun 27, 2022
@kiryldz kiryldz marked this pull request as ready for review June 27, 2022 07:42
@kiryldz kiryldz requested a review from a team as a code owner June 27, 2022 07:42
@kiryldz kiryldz force-pushed the MAPSAND-242-atmosphere-and-terrain-api-missing-transition-variables branch from a303a9d to fad4601 Compare June 27, 2022 08:00
@pengdev
Copy link
Member

pengdev commented Jun 27, 2022

Please make sure all the style instrumentation tests pass as well.

@kiryldz kiryldz merged commit df0885a into main Jun 27, 2022
@kiryldz kiryldz deleted the MAPSAND-242-atmosphere-and-terrain-api-missing-transition-variables branch June 27, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants