Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update telemetry to 8.1.5. #1494

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Update telemetry to 8.1.5. #1494

merged 4 commits into from
Jul 14, 2022

Conversation

yunikkk
Copy link
Contributor

@yunikkk yunikkk commented Jul 13, 2022

Summary of changes

Includes telemetry lib with fix for the crash when targetSdk = 31+ is used due to WorkManager 2.6 issues (mapbox/mapbox-events-android#571 (comment)).

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@yunikkk yunikkk requested a review from a team as a code owner July 13, 2022 08:14
@@ -1,7 +1,7 @@
object AndroidVersions {
const val minSdkVersion = 21
const val targetSdkVersion = 30
const val compileSdkVersion = 30
const val compileSdkVersion = 31
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to bump since new workmanager 2.7.1 from MME requires 31+

CHANGELOG.md Show resolved Hide resolved
@yunikkk yunikkk mentioned this pull request Jul 13, 2022
@yunikkk yunikkk merged commit 3da5fd1 into main Jul 14, 2022
@yunikkk yunikkk deleted the yds-mme-8.1.5 branch July 14, 2022 08:26
yunikkk added a commit that referenced this pull request Jul 14, 2022
* Update telemetry to 8.1.5.

* Update compileSdkVersion 31 to use workmanager 2.7.1.

* Fix merge of changelog.

* Mention minCompileSdk 31.
kiryldz pushed a commit that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants