[Android Auto] Add stable area changed callback #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmadsen
force-pushed
the
km-add-stable-area-listener
branch
from
03ac46a
to
488d17f
Compare
kmadsen
force-pushed
the
km-add-stable-area-listener
branch
from
488d17f
to
e5caab1
Compare
kmadsen
commented
Sep 21, 2022
| * loaded. This interface allows you to create custom Mapbox experiences for the car. | ||
| */ | ||
| @MapboxExperimental | ||
| interface MapboxCarMapObserver { |
There was a problem hiding this comment.
Moving to a java default interface
9 tasks
yunikkk
approved these changes
Sep 22, 2022
kiryldz
approved these changes
Sep 22, 2022
mapbox-github-ci-writer-public-1 bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
Co-authored-by: root <root@d251f5f56192>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Moving the
MapboxCarMapObserverto a java interface so that functions may be added in the future #1670Adding the
onStableAreaChangedin case there are usages for it.Improved the javadocs as they are slightly different in java files.
User impact (optional)
Pull request checklist:
@JvmOverloads,@file:JvmName, etc).make update-apito update generated api files, if there's public API changes, otherwise theverify-api-*CI steps might fail.check changelogCI step will fail.v10.[version]release branch fix / enhancement, merge it tomainfirstly and then port tov10.[version]release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.