[Android Auto] Backwards compatible interfaces using using jvm default #1674
Conversation
|
Closing here because this is the pull request used to resolve the issue #1670 |
|
Updating with a snapshot |
| @@ -32,6 +32,11 @@ android { | |||
| } | |||
| } | |||
|
|
|||
| // THIS IS REQUIRED or else it will not compile | |||
There was a problem hiding this comment.
Inheriting from MapboxCarMapObserver does not compile without this compiler flag when an sdk is built with the jvm-default=all flag
e: /Users/kylemadsen/Development/mapbox/mapbox-maps-android/android-auto-app/src/main/java/com/mapbox/maps/testapp/auto/car/CarAnimationThreadController.kt: (16, 7): Inheritance from an interface with '@JvmDefault' members is only allowed with -Xjvm-default option
Here is the compile error. It is nothing to do with CarAnimationThreadController except that it is inheriting from MapboxCarMapObserver. Also realize that it is the kotlin compiler that fails, not the CarJavaInterfaceChecker
|
Closing because this pull request is only showcasing the issue with a snapshot sdk that was created with the |
Summary of changes
See the discussion thread on this topic here #1670 (comment)
Opening this as a separate pull request as we may find new solutions that make this work. I will also fill in some more details next week.
User impact (optional)
Pull request checklist:
@JvmOverloads,@file:JvmName, etc).make update-apito update generated api files, if there's public API changes, otherwise theverify-api-*CI steps might fail.check changelogCI step will fail.v10.[version]release branch fix / enhancement, merge it tomainfirstly and then port tov10.[version]release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.