[viewannotation] Introduce show annotations api [MAPSAND-464] #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ank27
force-pushed
the
ak-viewannotation-frame-api
branch
from
48634cd
to
4ca6825
Compare
kiryldz
reviewed
Oct 17, 2022
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationManager.kt
Outdated
Show resolved
Hide resolved
yunikkk
reviewed
Oct 20, 2022
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationManager.kt
Outdated
Show resolved
Hide resolved
yunikkk
reviewed
Oct 20, 2022
yunikkk
reviewed
Oct 20, 2022
yunikkk
reviewed
Oct 20, 2022
ank27
changed the title
ank27
force-pushed
the
ak-viewannotation-frame-api
branch
2 times, most recently
from
b21127f
to
a3a0135
Compare
ank27
force-pushed
the
ak-viewannotation-frame-api
branch
2 times, most recently
from
29d26ea
to
6155c4a
Compare
kiryldz
reviewed
Oct 20, 2022
kiryldz
reviewed
Oct 20, 2022
kiryldz
reviewed
Oct 20, 2022
ank27
force-pushed
the
ak-viewannotation-frame-api
branch
from
6155c4a
to
555087a
Compare
jush
reviewed
Oct 25, 2022
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationManager.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationOptionsExt.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationOptionsExt.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationOptionsExt.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationOptionsExt.kt
Outdated
Show resolved
Hide resolved
ank27
force-pushed
the
ak-viewannotation-frame-api
branch
2 times, most recently
from
8b5cbd9
to
7a60489
Compare
ank27
requested review from
jush,
yunikkk,
alexander-kulikovskii,
kiryldz and
pengdev
kiryldz
reviewed
Oct 27, 2022
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationOptionsExt.kt
Outdated
Show resolved
Hide resolved
yunikkk
reviewed
Nov 1, 2022
yunikkk
reviewed
Nov 1, 2022
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationOptionsExt.kt
Outdated
Show resolved
Hide resolved
ank27
force-pushed
the
ak-viewannotation-frame-api
branch
from
ce27415
to
c121b28
Compare
kiryldz
reviewed
Nov 1, 2022
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationManager.kt
Show resolved
Hide resolved
ank27
force-pushed
the
ak-viewannotation-frame-api
branch
2 times, most recently
from
eb30475
to
da33a32
Compare
ank27
force-pushed
the
ak-viewannotation-frame-api
branch
3 times, most recently
from
b78ca74
to
58854ac
Compare
yunikkk
reviewed
Nov 1, 2022
yunikkk
reviewed
Nov 1, 2022
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationManager.kt
Outdated
Show resolved
Hide resolved
yunikkk
reviewed
Nov 1, 2022
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationManager.kt
Show resolved
Hide resolved
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationManager.kt
Show resolved
Hide resolved
ank27
force-pushed
the
ak-viewannotation-frame-api
branch
from
58854ac
to
9692f51
Compare
kiryldz
reviewed
Nov 2, 2022
sdk/src/main/java/com/mapbox/maps/viewannotation/ViewAnnotationManager.kt
Show resolved
Hide resolved
yunikkk
approved these changes
Nov 2, 2022
alexander-kulikovskii
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Introduce
ViewAnnotationManager.cameraForAnnotationsthat returnsCameraOptionsfor provided annotations. Users can use custom animation to move camera to fit specified anntations.If users set
ViewAnnotationOptions.visible = falseexplicitly, we will exclude those views from the calculation forcameraOptions. Also, only the views for which visibility is set to Visible, will be considered in the calculation.User impact (optional)
viewannotation_framing.mp4