Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose RenderWorldCopies property MAPSAND-588 #1794

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

alexander-kulikovskii
Copy link
Contributor

Summary of changes

Expose RenderWorldCopies property that sets whether multiple copies of the world will be rendered side by side beyond -180 and 180 degrees longitude.

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@alexander-kulikovskii alexander-kulikovskii requested a review from a team as a code owner November 2, 2022 13:54
@alexander-kulikovskii alexander-kulikovskii self-assigned this Nov 2, 2022
@alexander-kulikovskii alexander-kulikovskii requested a review from a team as a code owner November 2, 2022 13:54
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ank27 ank27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a question.

@alexander-kulikovskii alexander-kulikovskii changed the title expose RenderWorldCopies property MAPSMBL-184 expose RenderWorldCopies property MAPSAND-588 Nov 2, 2022
@alexander-kulikovskii alexander-kulikovskii merged commit de3d0e7 into main Nov 3, 2022
@alexander-kulikovskii alexander-kulikovskii deleted the kas-expose-render-world-copies branch November 3, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants