Fix a crash after removing the view annotation if view has an attached animation or transition #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. remove view annotation from currentlyDrawnViewIdSet as well 2. on edge cases (view has animation or transition) onViewDetachedFromWindow will not be called, so make sure we call it on removal to cleanup viewTreeObserver listener
9 tasks
kiryldz
changed the title
kiryldz
force-pushed
the
view-annotation-removal-fixes
branch
from
b00c3eb
to
3622b86
Compare
kiryldz
changed the title
kiryldz
force-pushed
the
view-annotation-removal-fixes
branch
from
3622b86
to
f504c4c
Compare
yunikkk
approved these changes
Nov 14, 2022
alexander-kulikovskii
approved these changes
Nov 14, 2022
kiryldz
added a commit
that referenced
this pull request
Nov 14, 2022
* fix: view annotation removal edge cases causes crash 1. remove view annotation from currentlyDrawnViewIdSet as well 2. on edge cases (view has animation or transition) onViewDetachedFromWindow will not be called, so make sure we call it on removal to cleanup viewTreeObserver listener * Add comment * changelog * Add test Co-authored-by: Miklós Fazekas <mfazekas@szemafor.com>
pengdev
pushed a commit
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Opened instead of #1829 to let CI pass.
Fixes: #1723
User impact (optional)
Pull request checklist:
@JvmOverloads,@file:JvmName, etc).make update-apito update generated api files, if there's public API changes, otherwise theverify-api-*CI steps might fail.check changelogCI step will fail.v10.[version]release branch fix / enhancement, merge it tomainfirstly and then port tov10.[version]release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.