-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash due to missing access token; delete CredentialsManager.kt #365
Conversation
Also thinking the ResourceOptionsManager stores the static default ResourceOptions, and access token is part of the ResourceOptions, so feels like CredentialsManager is redundant, shall we discuss whether we should remove the CredentialsManager? |
app/src/main/java/com/mapbox/maps/testapp/examples/MapViewCustomizationActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll drop 🚢 here as changes look ok to me and they fix a concrete bug. However perhaps we want to consider some alignment with iOS beforehand.
8ecf63e
to
8385455
Compare
Co-authored-by: Peng Liu <peng.liu@mapbox.com>
sdk/src/test/java/com/mapbox/maps/ResourceOptionsManagerTest.kt
Outdated
Show resolved
Hide resolved
sdk/src/test/java/com/mapbox/maps/ResourceAttributeParserTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
Co-authored-by: Peng Liu <peng.liu@mapbox.com>
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-android
changelog:<changelog>Fix crash due to missing access token; delete CredentialsManager.kt</changelog>
.Summary of changes
While users only set token in attr of MapView, a
MapboxConfigurationException
will be thrown as we can't find token from resource file and default value. This pr applies the token from attr to fix it.User impact (optional)