Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default ambient cache path to .mabox/maps/ambient_cache.db #373

Merged
merged 2 commits into from
May 27, 2021

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented May 27, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Change the default ambient cache path to .mabox/maps/ambient_cache.db</changelog>.

Summary of changes

This PR changes the default ambient cache path to .mapbox/maps/ambient_cache.db to align with default tile_store path.

User impact (optional)

@pengdev pengdev self-assigned this May 27, 2021
@pengdev pengdev requested review from a team and julianrex May 27, 2021 06:32
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pengdev pengdev merged commit e4f52fd into main May 27, 2021
@pengdev pengdev deleted the peng-update-cache-path branch May 27, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants