Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include xml attribute strings from res-public to sourceSet. #404

Merged
merged 3 commits into from
Jun 8, 2021

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented Jun 8, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Fixed an issue that public resource definitions are not generated in public.txt file.</changelog>.

Summary of changes

We use public.xml for indicating which attributes are private vs public (more context here). With using the public.xml configuration, we should be able to find a public.txt file in the resulting aar:

When building a library, the Android Gradle plugin gets the public resource definitions and extracts them into the public.txt file, which is then packaged inside the AAR file.

This is currently broken since we didn't configure the src/main/res-public to the sourceSet.

This PR includes public xml attribute strings from res-public to sourceSet.

User impact (optional)

@pengdev pengdev self-assigned this Jun 8, 2021
@pengdev pengdev marked this pull request as draft June 8, 2021 15:32
@pengdev pengdev requested a review from a team June 8, 2021 15:32
@pengdev pengdev added the bug 🪲 Something isn't working label Jun 8, 2021
@pengdev pengdev marked this pull request as ready for review June 8, 2021 16:44
@pengdev pengdev merged commit 6aa7811 into main Jun 8, 2021
@pengdev pengdev deleted the peng-fix-res-public branch June 8, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants